RFR: 8342393: Promote commutative vector IR node sharing [v10]

[Emanuel Peter]

On Fri, 24 Jan 2025 10:09:10 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Hi @vnkozlov , @iwanowww , @eme64 Please let me know if this looks good.
>
>> Hi @jatin-bhateja , the new change is more clear to me. Thanks for updating the predicate IR handling. Looks fine!
>> 
>> The only concern to me now is the test. I saw a series of IR checks in the added test. It seems some ones check the similar scenario. I'v added the comment in the test file. Could you please check? Thanks!
> 
> Hi @XiaohongGong 
> The intention here is to exercise all possible input combinations and IR ordering during GVN hashing, so there are explicit test points for (A1 + B1) + (B1 + A1) and (B1 + A1) + (A1 + B1) if that is what you are referring to.
> 
> Hi @eme64 , Can you kindly run the current patch through your test framework and share back the results

@jatin-bhateja This patch looks good now. Running testing again, feel free to ping me in 1-2 days!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22863#issuecomment-2615831095