RFR: 8315066: Add unsigned bounds and known bits to TypeInt/Long [v32]

Emanuel Peter epeter at openjdk.org
Mon Jan 27 14:49:04 UTC 2025


On Mon, 27 Jan 2025 14:36:46 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 44 commits:
>> 
>>  - remove precompiled.hpp
>>  - Merge branch 'master' into unsignedbounds
>>  - copyright
>>  - Merge branch 'master' into unsignedbounds
>>  - Merge branch 'master' into unsignedbounds
>>  - move try_cast to Type
>>  - Merge branch 'master' into unsignedbounds
>>  - build failure
>>  - build failures
>>  - whitespace
>>  - ... and 34 more: https://git.openjdk.org/jdk/compare/893d00ac...c4d46c87
>
> src/hotspot/share/opto/type.cpp line 1667:
> 
>> 1665:   assert(!_is_dual, "dual types should only be used for join calculation");
>> 1666:   const TypeInt* ft = join_helper(kills, include_speculative)->isa_int();
>> 1667:   if (ft == nullptr) {
> 
> Why can this now not be empty any more?

Or is that handled by the TypeInt constructor below?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17508#discussion_r1930639821


More information about the hotspot-compiler-dev mailing list