RFR: 8347718: Unexpected NullPointerException in C2 compiled code due to ReduceAllocationMerges [v2]
Cesar Soares Lucas
cslucas at openjdk.org
Mon Jan 27 18:22:31 UTC 2025
On Mon, 27 Jan 2025 16:51:48 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> Cesar Soares Lucas has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Address PR feedback: typo on test & move of igvn.transform
>
> src/hotspot/share/opto/escape.cpp line 1014:
>
>> 1012:
>> 1013: // This CMP always compares whether the output of "res_phi" is TRUE as far as the "mask".
>> 1014: Node* new_cmp = _igvn->transform(new CmpINode(res_phi, (mask == BoolTest::mask::eq) ? one : zero));
>
> Why we do `res_phi` transform (line 988) when we create it instead of after we assign inputs (after loop at line 1012)?
Probably just a copy and paste error.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23312#discussion_r1930992839
More information about the hotspot-compiler-dev
mailing list