RFR: 8347718: Unexpected NullPointerException in C2 compiled code due to ReduceAllocationMerges [v2]

Mon Jan 27 18:31:46 UTC 2025

On Mon, 27 Jan 2025 18:22:31 GMT, Cesar Soares Lucas <cslucas at openjdk.org> wrote:

>> Please, review this patch to fix an issue in reducing allocation merges used by Cmp nodes. The attached test case, adapted from the one attached to the JBS issue, can be used to reproduce the issue. The root of the problem was not properly checking the return value of `optimize_ptr_compare` against different Cmp mask predicates.
>> 
>> I tested this on OSX(ARM64) & Linux(Intel) tier1-4.
>
> Cesar Soares Lucas has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address PR feedback: typo on test & move of igvn.transform

Tentatively approved. Need run our testing before final approval.

-------------

PR Review: https://git.openjdk.org/jdk/pull/23312#pullrequestreview-2576248555