RFR: 8343938: TestStressBailout triggers "Should not be locked when freed" assert [v2]

Theo Weidmann tweidmann at openjdk.org
Tue Jan 28 08:31:36 UTC 2025


On Tue, 28 Jan 2025 06:41:17 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Theo Weidmann has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add asserts
>
> src/hotspot/share/compiler/compileTask.hpp line 180:
> 
>> 178:   // See how many threads are waiting for this task. Must have lock to read this.
>> 179:   int waiting_for_completion_count() { return _waiting_count; }
>> 180:   // Indicates that a thread is waiting for this task to complete. Must have lock to use this.
> 
> Should we add a `_lock->owned_by_self` assert here?

Thanks for the suggestion. I added the asserts.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23195#discussion_r1931719393


More information about the hotspot-compiler-dev mailing list