RFR: 8342393: Promote commutative vector IR node sharing [v19]
Jatin Bhateja
jbhateja at openjdk.org
Tue Jan 28 11:50:53 UTC 2025
On Tue, 28 Jan 2025 09:58:55 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Adding missed feature check
>
> test/hotspot/jtreg/compiler/vectorapi/VectorCommutativeOperSharingTest.java line 117:
>
>> 115: @IR(counts = {IRNode.XOR_VI, IRNode.VECTOR_SIZE_ANY, " 0 ",
>> 116: IRNode.OR_VI, IRNode.VECTOR_SIZE_ANY, " 1 ",
>> 117: IRNode.AND_VI, IRNode.VECTOR_SIZE_ANY, " 1 "})
>
> And this is not going to fail on any architecture? What about architectures other than x64 and aarch64? Do they all support the vector instructions?
>
> I'd rather not that this fails on their machines and then they have to fix it and we have to review their fix again ;)
Hi @eme64 ,
Attached script shows me that the greatest common divisor of targets supporting IR nodes in this test is x86 :-)
[get_c2_IR_supported_targets.txt](https://github.com/user-attachments/files/18572758/get_c2_IR_supported_targets.txt)

-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22863#discussion_r1932023187
More information about the hotspot-compiler-dev
mailing list