RFR: 8348658: [AArch64] The node limit in compiler/codegen/TestMatcherClone.java is too strict
Daniel Lundén
dlunden at openjdk.org
Wed Jan 29 15:40:18 UTC 2025
On some aarch64 machines, the node limit in the test `compiler/codegen/TestMatcherClone.java` is too strict.
### Changeset
On the aarch64 machine I used when developing the fix for [JDK-8331295](https://bugs.openjdk.org/browse/JDK-8331295), the fix caused the node count in the test to decrease from 522 to 174. As a result, I set the IR framework node count limit to <200 to capture this. @shipilev now reports that on another aarch64 machine, the fix instead results in a decrease from 696 to 350. Since the fix for [JDK-8331295](https://bugs.openjdk.org/browse/JDK-8331295) still applies (the node count indeed decreases as expected), we should adjust the limit to somewhere in between 350 and 522 to capture both cases. 400 seems like a reasonable value and is what I propose in this PR.
### Testing
- [GitHub Actions](https://github.com/dlunde/jdk/actions/runs/13014279125)
- `tier1` and HotSpot parts of `tier2` and `tier3` on Windows x64, Linux x64, Linux aarch64, macOS x64, and macOS aarch64.
- Extra testing of `TestMatcherClone.java` with various flag combinations.
-------------
Commit messages:
- Increase TestMatcherClone limit
Changes: https://git.openjdk.org/jdk/pull/23349/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23349&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8348658
Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
Patch: https://git.openjdk.org/jdk/pull/23349.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/23349/head:pull/23349
PR: https://git.openjdk.org/jdk/pull/23349
More information about the hotspot-compiler-dev
mailing list