RFR: 8349138: Optimize Math.copySign API for Intel e-core targets
Jatin Bhateja
jbhateja at openjdk.org
Fri Jan 31 11:36:31 UTC 2025
Math.copySign is only intrinsified on x86 targets supporting the AVX512 feature.
Intel E-core Xeons support only the AVX2 feature set and still compile Java implementation which is composed of logical operations.
Since there is a 3-cycle penalty for copying incoming float/double values to GPRs before being operated upon by logical operation there is an opportunity to optimize this using an efficient instruction sequence.
Patch uses ANDPS and ANDPD logical instruction to generate efficient instruction sequences to absorb domain copy over penalty. Also, performs minor tuning for existing AVX512 instruction sequence based on VPTERNLOG instruction.
Following are the performance numbers of existing microbenchmark
https://github.com/openjdk/jdk/blob/master/test/micro/org/openjdk/bench/vm/compiler/Signum.java
Patch passes existing validation test
[test/jdk/java/lang/Math/IeeeRecommendedTests.java
](https://github.com/openjdk/jdk/blob/master/test/jdk/java/lang/Math/IeeeRecommendedTests.java)
Granite Rapids-AP (P-core Xeon)
Baseline AVX512:
Benchmark Mode Cnt Score Error Units
Signum._5_copySignFloatTest thrpt 2 1296.141 ops/ns
Signum._7_copySignDoubleTest thrpt 2 838.954 ops/ns
Withopt :
Benchmark Mode Cnt Score Error Units
Signum._5_copySignFloatTest thrpt 2 940.240 ops/ns
Signum._7_copySignDoubleTest thrpt 2 967.370 ops/ns
Baseline AVX2:
Benchmark Mode Cnt Score Error Units
Signum._5_copySignFloatTest thrpt 2 63.673 ops/ns
Signum._7_copySignDoubleTest thrpt 2 26.898 ops/ns
Withopt :
Benchmark Mode Cnt Score Error Units
Signum._5_copySignFloatTest thrpt 2 785.801 ops/ns
Signum._7_copySignDoubleTest thrpt 2 558.710 ops/ns
Sierra Forest (E-core Xeon)
Baseline:
Benchmark (seed) Mode Cnt Score Error Units
o.o.b.vm.compiler.Signum._5_copySignFloatTest N/A thrpt 2 40.528 ops/ns
o.o.b.vm.compiler.Signum._7_copySignDoubleTest N/A thrpt 2 25.101 ops/ns
Withopt:
Benchmark (seed) Mode Cnt Score Error Units
o.o.b.vm.compiler.Signum._5_copySignFloatTest N/A thrpt 2 676.101 ops/ns
o.o.b.vm.compiler.Signum._7_copySignDoubleTest N/A thrpt 2 605.714 ops/ns
-------------
Commit messages:
- 8349138: Optimize Math.copySign API for Intel e-core and p-core targets
Changes: https://git.openjdk.org/jdk/pull/23386/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23386&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8349138
Stats: 78 lines in 1 file changed: 44 ins; 5 del; 29 mod
Patch: https://git.openjdk.org/jdk/pull/23386.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/23386/head:pull/23386
PR: https://git.openjdk.org/jdk/pull/23386
More information about the hotspot-compiler-dev
mailing list