RFR: 8346280: C2: implement late barrier elision for G1 [v2]

Roberto Castañeda Lozano rcastanedalo at openjdk.org
Fri Jan 31 14:09:44 UTC 2025


On Fri, 31 Jan 2025 08:54:20 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> One question about elision for atomics.
> 
> Otherwise it seems good afaict, although a large part was checking that the code movement is/was correct.

Thanks for reviewing Thomas! Please let me know whether you want me to extend this changeset to elide barriers on atomic operations (happy to do so).

> src/hotspot/share/gc/shared/c2/barrierSetC2.cpp line 1048:
> 
>> 1046:     return false;
>> 1047:   }
>> 1048:   const TypePtr* const adr_type = nullptr;
> 
> pre-existing: `adr_type` is unused in the following.

Removed (commit 3d154fa8), thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23235#issuecomment-2627437036
PR Review Comment: https://git.openjdk.org/jdk/pull/23235#discussion_r1937370541


More information about the hotspot-compiler-dev mailing list