RFR: 8349142: [JMH] compiler.MergeLoadBench.getCharBV fails [v2]

SendaoYan syan at openjdk.org
Fri Jan 31 15:59:06 UTC 2025


On Fri, 31 Jan 2025 15:48:52 GMT, Shaojin Wen <swen at openjdk.org> wrote:

>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove Unsafe.ARRAY_BYTE_BASE_OFFSET from second argument of VarHandle.get
>
> test/micro/org/openjdk/bench/vm/compiler/MergeLoadBench.java line 320:
> 
>> 318:         long sum = 0;
>> 319:         for (int i = 0; i < longs.length; i++) {
>> 320:             char c = (char) CHAR_B.get(bytes4, (int)(Unsafe.ARRAY_BYTE_BASE_OFFSET + i * 2));
> 
> char c = (char) CHAR_B.get(bytes4, i * 2);
> 
> it should be changed like this

Thanks. The `Unsafe.ARRAY_BYTE_BASE_OFFSET` has been removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23393#discussion_r1937531000


More information about the hotspot-compiler-dev mailing list