RFR: 8349142: [JMH] compiler.MergeLoadBench.getCharBV fails [v2]
Chen Liang
liach at openjdk.org
Fri Jan 31 16:44:50 UTC 2025
On Fri, 31 Jan 2025 15:59:06 GMT, SendaoYan <syan at openjdk.org> wrote:
>> Hi all,
>>
>> There are two JMH tests fails after [JDK-8344168](https://bugs.openjdk.org/browse/JDK-8344168) merged. This PR fix the JMH tests fails similar to https://github.com/oracle/graal/pull/10602, just remove the unnecessary Unsafe.ARRAY_BYTE_BASE_OFFSET at the second argument of VarHandle.get.
>> Change has been verified locally, test-fix only, no risk.
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>
> remove Unsafe.ARRAY_BYTE_BASE_OFFSET from second argument of VarHandle.get
Looks good, thanks for fixing these misuses of Unsafe.ARRAY_BYTE_BASE_OFFSET. Looks like a copy-paste error when the benchmark was created, but this wasn't statically detected until the VarHandle type checks failed due to the long offsets.
-------------
Marked as reviewed by liach (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23393#pullrequestreview-2587268308
More information about the hotspot-compiler-dev
mailing list