RFR: 8360936: Test compiler/onSpinWait/TestOnSpinWaitAArch64.java fails after JDK-8359435

Aleksey Shipilev shade at openjdk.org
Tue Jul 1 15:39:43 UTC 2025


On Tue, 1 Jul 2025 15:29:10 GMT, Evgeny Astigeevich <eastigeevich at openjdk.org> wrote:

> Test compiler/onSpinWait/TestOnSpinWaitAArch64.java needs debug info to identify a position of spin wait instructions in generated code. Release builds might not generate needed debug info.
> 
> This PR adds a requirement for the test to be run on debug builds only.
> 
> Tested:
> - Fastdebug: test passed
> - Slowdebug: test passed.
> - Release: test skipped.

Looks okay, but I am confused why the test did not fail before JDK-8359435?

test/hotspot/jtreg/compiler/onSpinWait/TestOnSpinWaitAArch64.java line 32:

> 30:  * @requires vm.flagless
> 31:  * @requires os.arch=="aarch64"
> 32:  * @requires vm.debug==true

Can be just `@requires vm.debug`.

-------------

PR Review: https://git.openjdk.org/jdk/pull/26072#pullrequestreview-2975983374
PR Review Comment: https://git.openjdk.org/jdk/pull/26072#discussion_r2177921439


More information about the hotspot-compiler-dev mailing list