RFR: 8360936: Test compiler/onSpinWait/TestOnSpinWaitAArch64.java fails after JDK-8359435 [v2]

[Evgeny Astigeevich]

On Tue, 1 Jul 2025 16:05:07 GMT, Evgeny Astigeevich <eastigeevich at openjdk.org> wrote:

>> Test compiler/onSpinWait/TestOnSpinWaitAArch64.java needs debug info to identify a position of spin wait instructions in generated code. Release builds might not generate needed debug info.
>> 
>> This PR adds a requirement for the test to be run on debug builds only.
>> 
>> Tested:
>> - Fastdebug: test passed
>> - Slowdebug: test passed.
>> - Release: test skipped.
>
> Evgeny Astigeevich has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Simplify requirement for debug build

I finished bisecting. This is my changes in the test which made it failing:

@@ -56,7 +58,6 @@ public static void main(String[] args) throws Exception {
         command.add("-showversion");
         command.add("-XX:-BackgroundCompilation");
         command.add("-XX:+UnlockDiagnosticVMOptions");
-        command.add("-XX:+PrintAssembly");
         if (compiler.equals("c2")) {
             command.add("-XX:-TieredCompilation");
         } else if (compiler.equals("c1")) {
@@ -69,13 +70,17 @@ public static void main(String[] args) throws Exception {
         command.add("-XX:OnSpinWaitInst=" + spinWaitInst);
         command.add("-XX:OnSpinWaitInstCount=" + spinWaitInstCount);
         command.add("-XX:CompileCommand=compileonly," + Launcher.class.getName() + "::" + "test");
+        command.add("-XX:CompileCommand=print," + Launcher.class.getName() + "::" + "test");
         command.add(Launcher.class.getName());


It looks like `XX:+PrintAssembly` prints out debug info in release builds but `XX:CompileCommand=print` does not.
I am switching back to `XX:+PrintAssembly`.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26072#issuecomment-3026790161