RFR: 8359120: Improve warning message when fail to load hsdis library [v2]

Tobias Hartmann thartmann at openjdk.org
Wed Jul 2 07:50:52 UTC 2025


On Mon, 30 Jun 2025 11:08:45 GMT, Taizo Kurashige <tkurashige at openjdk.org> wrote:

> but since nullptr is passed at [src/hotspot/share/compiler/disassembler.hpp#L66](https://github.com/openjdk/jdk/blob/c2d76f9844aadf77a0b213a9169a7c5c8c8f1ffb/src/hotspot/share/compiler/disassembler.hpp#L66), that reporting doesn't actually work.

Right, it will be set to `tty` when Verbose is true:
https://github.com/openjdk/jdk/blob/c2d76f9844aadf77a0b213a9169a7c5c8c8f1ffb/src/hotspot/share/compiler/disassembler.cpp#L780

Thanks for the additional details of why you decided to not use that code. I'm fine with these changes.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25726#issuecomment-3026818978


More information about the hotspot-compiler-dev mailing list