RFR: 8348868: AArch64: Add backend support for SelectFromTwoVector [v8]
Bhavana Kilambi
bkilambi at openjdk.org
Wed Jul 2 08:26:01 UTC 2025
On Fri, 27 Jun 2025 15:21:28 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> Bhavana Kilambi has updated the pull request incrementally with one additional commit since the last revision:
>>
>> code style issues fixed
>
> src/hotspot/cpu/aarch64/assembler_aarch64.hpp line 4231:
>
>> 4229:
>> 4230: // SVE/SVE2 Programmable table lookup in one or two vector table (zeroing)
>> 4231: void sve_tbl(FloatRegister Zd, SIMD_RegVariant T, FloatRegister Zn, unsigned reg_count, FloatRegister Zm) {
>
> [Edited]
>
> This would be better:
>
> private:
> void _sve_tbl(FloatRegister Zd, SIMD_RegVariant T, FloatRegister Zn, unsigned reg_count, FloatRegister Zm) {
>
>
> ... then 2 patterns ...
>
>
> public:
> void sve_tbl(FloatRegister Zd, SIMD_RegVariant T, FloatRegister Zn1, FloatRegister Zn2, FloatRegister Zm);
> void sve_tbl(FloatRegister Zd, SIMD_RegVariant T, FloatRegister Zn, FloatRegister Zm);
>
>
> ... and make sure that `Zn1+ 1 == Zn2`
Done. Please review the latest patch. Thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23570#discussion_r2179438846
More information about the hotspot-compiler-dev
mailing list