RFR: 8361144: Strenghten the Ideal Verification in PhaseIterGVN::verify_Ideal_for by comparing the hash of a node before and after Ideal [v3]

[Benoît Maillard]

On Wed, 2 Jul 2025 06:55:34 GMT, Damon Fenacci <dfenacci at openjdk.org> wrote:

>> Benoît Maillard has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8361144: add comment for consistency with node count
>
> src/hotspot/share/opto/phaseX.cpp line 1821:
> 
>> 1819:   // The number of nodes shoud not increase.
>> 1820:   uint old_unique = C->unique();
>> 1821:   uint old_hash = n->hash();
> 
> Just to be consistent with `old_unique` we could add a small comment (here or below for both). What do you think?

Sounds reasonable! Made the update

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26064#discussion_r2179682863