RFR: 8358179: Performance regression in Math.cbrt [v2]

Mohamed Issa missa at openjdk.org
Wed Jul 2 14:58:50 UTC 2025


On Wed, 2 Jul 2025 11:25:33 GMT, Yudi Zheng <yzheng at openjdk.org> wrote:

>> Mohamed Issa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Ensure ABS_MASK is a 128-bit memory sized location and only use equal enum for UCOMISD checks
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_cbrt.cpp line 350:
> 
>> 348: 
>> 349:   __ bind(L_2TAG_PACKET_6_0_1);
>> 350:   __ movsd(xmm0, ExternalAddress(NEG_INF), r11 /*rscratch*/);
> 
> note that `NEG_INF` is now unused

Got it - thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25962#discussion_r2180280115


More information about the hotspot-compiler-dev mailing list