RFR: 8360936: Test compiler/onSpinWait/TestOnSpinWaitAArch64.java fails after JDK-8359435 [v3]
Evgeny Astigeevich
eastigeevich at openjdk.org
Thu Jul 3 08:18:56 UTC 2025
> Test compiler/onSpinWait/TestOnSpinWaitAArch64.java needs debug info to identify a position of spin wait instructions in generated code. The test switched to use `XX:CompileCommand=print` instead of `XX:+PrintAssembly` to have assembly only for a tested Java method. In release builds `XX:+PrintAssembly` prints out debug info but `XX:CompileCommand=print` does not.
>
> This PR reimplements the test to parse instructions and to check them. The test does not rely on debug info anymore.
>
> Tested on Linux and MacOS with and without hsdis:
> - Fastdebug: test passed
> - Slowdebug: test passed.
> - Release: test passed.
Evgeny Astigeevich has updated the pull request incrementally with one additional commit since the last revision:
Reimplement checking algo without using debug info
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/26072/files
- new: https://git.openjdk.org/jdk/pull/26072/files/e91036bc..0b3320e6
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=26072&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=26072&range=01-02
Stats: 139 lines in 1 file changed: 49 ins; 66 del; 24 mod
Patch: https://git.openjdk.org/jdk/pull/26072.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/26072/head:pull/26072
PR: https://git.openjdk.org/jdk/pull/26072
More information about the hotspot-compiler-dev
mailing list