RFR: 8361255: CTW: Tolerate more NCDFE problems [v2]

Aleksey Shipilev shade at openjdk.org
Thu Jul 3 13:33:24 UTC 2025


On Thu, 3 Jul 2025 11:14:41 GMT, Galder Zamarreño <galder at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8361255-ctw-ncdfe
>>  - Move clinit compile back
>>  - Initial
>>  - Fix
>
> test/hotspot/jtreg/testlibrary/ctw/src/sun/hotspot/tools/ctw/Compiler.java line 104:
> 
>> 102:             constructors = aClass.getDeclaredConstructors();
>> 103:         } catch (NoClassDefFoundError e) {
>> 104:             CompileTheWorld.OUT.println(String.format("[%d]\t%s\tNOTE unable to get constructors : %s",
> 
> Nitpick really but why not call `CompileTheWorld.OUT.printf(...` instead of `CompileTheWorld.OUT.println(String.format(...`?

Mostly because it was the style of the surrounding code. But I don't see why not use `printf` directly indeed, done in new commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26090#discussion_r2182798874


More information about the hotspot-compiler-dev mailing list