RFR: 8361353: [PPC64] C2: Add nodes UMulHiL, CmpUL3, UMinV, UMaxV, NegVI
    Martin Doerr 
    mdoerr at openjdk.org
       
    Thu Jul  3 14:27:42 UTC 2025
    
    
  
On Thu, 3 Jul 2025 12:30:51 GMT, David Briemann <dbriemann at openjdk.org> wrote:
> Implement more nodes for ppc that exist on other platforms.
Thanks for implementing these nodes! The new instruction needs a Power9 check. Otherwise, LGTM.
src/hotspot/cpu/ppc/assembler_ppc.hpp line 2376:
> 2374:   inline void vctzw(    VectorRegister d, VectorRegister b);
> 2375:   inline void vctzd(    VectorRegister d, VectorRegister b);
> 2376:   inline void vnegw(    VectorRegister d, VectorRegister b);
A Power9 comment would be helpful to prevent wrong usage.
src/hotspot/cpu/ppc/ppc.ad line 2196:
> 2194:     case Op_AbsVF:
> 2195:     case Op_AbsVD:
> 2196:     case Op_NegVI:
vnegw requires Power9 (`PowerArchitecturePPC64 >= 9`).
src/hotspot/cpu/ppc/ppc.ad line 13583:
> 13581: 
> 13582: instruct vnegI_reg(vecX dst, vecX src) %{
> 13583:   match(Set dst (NegVI src));
Should use a predicate for Power9.
-------------
PR Review: https://git.openjdk.org/jdk/pull/26115#pullrequestreview-2983369466
PR Review Comment: https://git.openjdk.org/jdk/pull/26115#discussion_r2182917169
PR Review Comment: https://git.openjdk.org/jdk/pull/26115#discussion_r2182910035
PR Review Comment: https://git.openjdk.org/jdk/pull/26115#discussion_r2182926525
    
    
More information about the hotspot-compiler-dev
mailing list