RFR: 8359678: C2: assert(static_cast<T1>(result) == thing) caused by ReverseBytesNode::Value() [v2]

Hannes Greule hgreule at openjdk.org
Fri Jul 4 06:36:44 UTC 2025


On Fri, 4 Jul 2025 06:04:42 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Hannes Greule has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove classfile version
>
> test/hotspot/jtreg/compiler/c2/gvn/ReverseBytesConstantsTests.java line 23:
> 
>> 21:  * questions.
>> 22:  */
>> 23: package compiler.c2.gvn;
> 
> Why did you remove the package? You can add the `jasm` file to the package too, I think that should work, no?

It seems like most files in the gvn folder don't have a package declaration, that's why I thought adjusting this way is fine. But I can also add it back and put the jasm file in the package too.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25988#discussion_r2184531892


More information about the hotspot-compiler-dev mailing list