RFR: 8358568: C2 compilation hits "must have a monitor" assert with -XX:-GenerateSynchronizationCode [v4]

hanguanqiang duke at openjdk.org
Fri Jul 4 06:47:39 UTC 2025


On Fri, 4 Jul 2025 06:12:44 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> hanguanqiang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Delete .gitpod.yml
>
> src/hotspot/share/opto/callnode.cpp line 1456:
> 
>> 1454:   Node* top = Compile::current()->top();
>> 1455:   ins_req(nextmon, top);
>> 1456:   ins_req(nextmon, top);
> 
> Wait, this is wrong. The monitor inputs should not be set to top.

@TobiHartmann Thank you for pointing out the issue — I’ve made the correction as suggested.
Could you please take another look when you have time?
Thanks again for your review and feedback

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26108#discussion_r2184546780


More information about the hotspot-compiler-dev mailing list