RFR: 8358568: Purge obsolete/broken GenerateSynchronizationCode flag [v5]

Tobias Hartmann thartmann at openjdk.org
Fri Jul 4 11:05:43 UTC 2025


On Fri, 4 Jul 2025 06:43:02 GMT, hanguanqiang <duke at openjdk.org> wrote:

>> This PR fixes JDK-8358568, a JVM crash triggered when running with -XX:-GenerateSynchronizationCode
>> 
>> Problem:
>> When synchronization code generation is disabled by -XX:-GenerateSynchronizationCode, the compiler’s do_monitor_exit() method still tries to access monitor objects without checking if any monitors exist.This causes an assertion failure and JVM crash.
>> 
>> Root Cause:
>> Parse::do_monitor_exit() calls shared_unlock() using monitor info unconditionally,but with GenerateSynchronizationCode disabled, no monitor info is available, leading to invalid access.
>> 
>> Fix
>> Purge obsolete/broken GenerateSynchronizationCode flag
>
> hanguanqiang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   correct an error
>   
>   correct an error

Looks good.

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/26108#pullrequestreview-2986682348


More information about the hotspot-compiler-dev mailing list