RFR: 8361353: [PPC64] C2: Add nodes UMulHiL, CmpUL3, UMinV, UMaxV, NegVI [v5]

[Martin Doerr]

On Fri, 4 Jul 2025 11:31:24 GMT, David Briemann <dbriemann at openjdk.org> wrote:

>> Implement more nodes for ppc that exist on other platforms.
>
> David Briemann has updated the pull request incrementally with one additional commit since the last revision:
> 
>   adjust parameter types

This looks correct, now. I only have a minor suggestion.

src/hotspot/cpu/ppc/ppc.ad line 13599:

> 13597: %}
> 13598: 
> 13599: instruct vnegI_reg(vecX dst, vecX src) %{

Maybe call it vneg4I? That would be more consistent with the other nodes.

src/hotspot/cpu/ppc/ppc.ad line 13601:

> 13599: instruct vnegI_reg(vecX dst, vecX src) %{
> 13600:   match(Set dst (NegVI src));
> 13601:   predicate(PowerArchitecturePPC64 >= 9);

We could also for check n->as_Vector()->length() == 4 or type int.

-------------

Marked as reviewed by mdoerr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/26115#pullrequestreview-2986896415
PR Review Comment: https://git.openjdk.org/jdk/pull/26115#discussion_r2185175993
PR Review Comment: https://git.openjdk.org/jdk/pull/26115#discussion_r2185177259