RFR: 8344548: Incorrect StartAggressiveSweepingAt doc for segmented code cache [v2]
Vladimir Kozlov
kvn at openjdk.org
Tue Jul 8 02:06:39 UTC 2025
On Fri, 4 Jul 2025 14:13:27 GMT, guanqiang han <duke at openjdk.org> wrote:
>> The flag StartAggressiveSweepingAt triggers aggressive code cache sweeping based on the percentage of free space in the entire code cache. The previous description referenced segmented vs non-segmented code cache, which is confusing and does not reflect the current implementation.
>>
>> This patch updates the flag description to clearly state that the threshold is based on the total code cache free percentage, regardless of segmentation.
>
> guanqiang han has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - correct a compile error
> - Merge remote-tracking branch 'upstream/master' into 8344548
> - 8344548: Incorrect StartAggressiveSweepingAt doc for segmented code cache
>
> The flag StartAggressiveSweepingAt triggers aggressive code cache sweeping based on the percentage of free space in the entire code cache. The previous description referenced segmented vs non-segmented code cache, which is
> confusing and does not reflect the current implementation.
>
> This patch updates the flag description to clearly state that the threshold is based on the total code cache free percentage, regardless of segmentation.
src/hotspot/share/runtime/globals.hpp line 1573:
> 1571: \
> 1572: product(uintx, StartAggressiveSweepingAt, 10, \
> 1573: "Start aggressive sweeping if X[%] of the total code cache is free.")\
I suggest : "Start aggressive sweeping if less than X[%] of the total code cache is free.")
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26114#discussion_r2191326749
More information about the hotspot-compiler-dev
mailing list