RFR: 8342941: IGV: Add new graph dumps for post loop, empty loop removal, and one iteration removal [v3]
Christian Hagedorn
chagedorn at openjdk.org
Tue Jul 8 06:15:42 UTC 2025
On Mon, 7 Jul 2025 23:04:51 GMT, Saranya Natarajan <snatarajan at openjdk.org> wrote:
>> This changeset adds BEFORE/AFTER graph dumps for creating a post loop (`insert_post_loop()`), removing an empty loop (`do_remove_empty_loop()`), and removing a one iteration loop (`do_one_iteration_loop()`).
>>
>> Changes:
>> - Added `BEFORE_POST_LOOP` and `AFTER_POST_LOOP` for dumping graphs before and after `insert_post_loop()`.
>> - Added `BEFORE_REMOVE_EMPTY_LOOP` and `AFTER_REMOVE_EMPTY_LOOP` for dumping graphs before and after `do_remove_empty_loop()`.
>> - Added `BEFORE_ONE_ITERATION_LOOP` and `AFTER_ONE_ITERATION_LOOP` for dumping graphs before and after `do_one_iteration_loop()`.
>>
>> Below are sample screenshots (IGV print level 4 ) mainly showing the new phase .
>> 1. `BEFORE_POST_LOOP` and `AFTER_POST_LOOP`
>> 
>> 2. `BEFORE_POST_LOOP` and `AFTER_POST_LOOP` with SuperWordLoopUnrollAnalysis enabled
>> 
>> 3.` BEFORE_REMOVE_EMPTY_LOOP `and `AFTER_REMOVE_EMPTY_LOOP`
>> 
>> 4. `BEFORE_ONE_ITERATION_LOOP` and `AFTER_ONE_ITERATION_LOOP`
>> 
>>
>> Question to reviewers:
>> Are the new compiler phases OK, or should we change anything?
>>
>> Testing:
>> GitHub Actions
>> tier1 to tier5 on windows-x64, linux-x64, linux-aarch64, macosx-x64, and macosx-aarch64.
>> Tested that thousands of graphs are correctly opened and visualized with IGV using the same test used in ([JDK-8317349](https://bugs.openjdk.org/browse/JDK-8317349))
>
> Saranya Natarajan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
>
> - fix 2 of review
> - Merge master
> - Addressing review comments
> - Initial Fix
Update looks good, thanks!
-------------
Marked as reviewed by chagedorn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/25756#pullrequestreview-2996119957
More information about the hotspot-compiler-dev
mailing list