RFR: 8344548: Incorrect StartAggressiveSweepingAt doc for segmented code cache [v3]
Vladimir Kozlov
kvn at openjdk.org
Tue Jul 8 07:20:40 UTC 2025
On Tue, 8 Jul 2025 03:26:18 GMT, guanqiang han <duke at openjdk.org> wrote:
>> The flag StartAggressiveSweepingAt triggers aggressive code cache sweeping based on the percentage of free space in the entire code cache. The previous description referenced segmented vs non-segmented code cache, which is confusing and does not reflect the current implementation.
>>
>> This patch updates the flag description to clearly state that the threshold is based on the total code cache free percentage, regardless of segmentation.
>
> guanqiang han has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>
> - make description more precise
> - Merge remote-tracking branch 'upstream/master' into 8344548
> - correct a compile error
> - Merge remote-tracking branch 'upstream/master' into 8344548
> - 8344548: Incorrect StartAggressiveSweepingAt doc for segmented code cache
>
> The flag StartAggressiveSweepingAt triggers aggressive code cache sweeping based on the percentage of free space in the entire code cache. The previous description referenced segmented vs non-segmented code cache, which is
> confusing and does not reflect the current implementation.
>
> This patch updates the flag description to clearly state that the threshold is based on the total code cache free percentage, regardless of segmentation.
Good.
-------------
Marked as reviewed by kvn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/26114#pullrequestreview-2996300301
More information about the hotspot-compiler-dev
mailing list