RFR: 8357473: Compilation spike leaves many CompileTasks in free list [v5]

[Aleksey Shipilev]

On Tue, 8 Jul 2025 07:17:20 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:
>> 
>>  - Merge branch 'master' into JDK-8357473-compile-task-free-list
>>  - Merge branch 'master' into JDK-8357473-compile-task-free-list
>>  - Merge branch 'master' into JDK-8357473-compile-task-free-list
>>  - Merge branch 'master' into JDK-8357473-compile-task-free-list
>>  - Also free the lock!
>>  - Comments and indenting
>>  - Basic deletion
>
> src/hotspot/share/compiler/compileTask.cpp line 84:
> 
>> 82: 
>> 83: CompileTask::~CompileTask() {
>> 84:   if ((_method_holder != nullptr && JNIHandles::is_weak_global_handle(_method_holder))) {
> 
> While moving the code, you can probably remove one pair of parentheses here:
> Suggestion:
> 
>   if (_method_holder != nullptr && JNIHandles::is_weak_global_handle(_method_holder)) {

Sure, done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25409#discussion_r2191898167