RFR: 8360936: Test compiler/onSpinWait/TestOnSpinWaitAArch64.java fails after JDK-8359435 [v4]
Aleksey Shipilev
shade at openjdk.org
Tue Jul 8 09:38:42 UTC 2025
On Tue, 8 Jul 2025 09:21:03 GMT, Evgeny Astigeevich <eastigeevich at openjdk.org> wrote:
>> But this is a generic macroAssembler block comment. It does not make sense to me to have a block comment that looks like a memory corrupted string, just to satisfy a single test. There should be a middle-ground here, e.g. `spin_wait {`, which looks reasonably enough as the block comment, and not anything else. Would also match nicely when we emit the closing `}` at the end of the instruction block.
>
> I like the idea of having `{`, `}`.
> IMO this should be informative:
>
> ;; spin_wait_3_nop {
> nop
> nop
> nop
> ;; }
Putting `_3_nop` might be convenient, but I think that would introduce too much hassle in macroAssembler? Just this looks okay to me:
;; spin_wait {
nop
nop
nop
;; }
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26072#discussion_r2191990275
More information about the hotspot-compiler-dev
mailing list