RFR: 8360936: Test compiler/onSpinWait/TestOnSpinWaitAArch64.java fails after JDK-8359435 [v4]
Andrew Haley
aph at openjdk.org
Wed Jul 9 08:30:42 UTC 2025
On Tue, 8 Jul 2025 12:03:33 GMT, Evgeny Astigeevich <eastigeevich at openjdk.org> wrote:
>>> Erm, I don't see why?
>>
>> To make it unique? I don't see why you don't see that we need to ensure that the string is unique.
>
> @theRealAph, are you okay with the latest variant Aleksey proposes?
> But this is a generic macroAssembler block comment. It does not make sense to me to have a block comment that looks like a memory corrupted string, just to satisfy a single test. There should be a middle-ground here, e.g. `spin_wait {`, which looks reasonably enough as the block comment, and not anything else. Would also match nicely when we emit the closing `}` at the end of the instruction block.
OK
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26072#discussion_r2194396280
More information about the hotspot-compiler-dev
mailing list