RFR: 8360936: Test compiler/onSpinWait/TestOnSpinWaitAArch64.java fails after JDK-8359435 [v7]

Evgeny Astigeevich eastigeevich at openjdk.org
Wed Jul 9 15:58:02 UTC 2025


> Test compiler/onSpinWait/TestOnSpinWaitAArch64.java needs debug info to identify a position of spin wait instructions in generated code. The test switched to use `XX:CompileCommand=print` instead of `XX:+PrintAssembly` to have assembly only for a tested Java method. In release builds  `XX:+PrintAssembly` prints out debug info but `XX:CompileCommand=print` does not.
> 
> This PR reimplements the test to parse instructions and to check them. The test does not rely on debug info anymore.
> 
> Tested on Linux and MacOS with and without hsdis:
> - Fastdebug: test passed
> - Slowdebug: test passed.
> - Release: test passed.

Evgeny Astigeevich has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:

 - Merge branch 'master' into JDK-8360936
 - Update spin_wait block comment
 - Fix whitespace error
 - Implement using block_comment
 - Reimplement checking algo without using debug info
 - Simplify requirement for debug build
 - 8360936: Test compiler/onSpinWait/TestOnSpinWaitAArch64.java fails after JDK-8359435

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/26072/files
  - new: https://git.openjdk.org/jdk/pull/26072/files/6d60fb42..8554242b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=26072&range=06
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=26072&range=05-06

  Stats: 14617 lines in 539 files changed: 8622 ins; 2314 del; 3681 mod
  Patch: https://git.openjdk.org/jdk/pull/26072.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/26072/head:pull/26072

PR: https://git.openjdk.org/jdk/pull/26072


More information about the hotspot-compiler-dev mailing list