RFR: 8360936: Test compiler/onSpinWait/TestOnSpinWaitAArch64.java fails after JDK-8359435 [v7]

[Aleksey Shipilev]

On Wed, 9 Jul 2025 15:58:02 GMT, Evgeny Astigeevich <eastigeevich at openjdk.org> wrote:

>> Test compiler/onSpinWait/TestOnSpinWaitAArch64.java needs debug info to identify a position of spin wait instructions in generated code. The test switched to use `XX:CompileCommand=print` instead of `XX:+PrintAssembly` to have assembly only for a tested Java method. In release builds  `XX:+PrintAssembly` prints out debug info but `XX:CompileCommand=print` does not.
>> 
>> This PR reimplements the test to parse instructions and to check them. The test does not rely on debug info anymore.
>> 
>> Tested on Linux and MacOS with and without hsdis:
>> - Fastdebug: test passed
>> - Slowdebug: test passed.
>> - Release: test passed.
>
> Evgeny Astigeevich has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8360936
>  - Update spin_wait block comment
>  - Fix whitespace error
>  - Implement using block_comment
>  - Reimplement checking algo without using debug info
>  - Simplify requirement for debug build
>  - 8360936: Test compiler/onSpinWait/TestOnSpinWaitAArch64.java fails after JDK-8359435

Good patch. I propose a few cosmetics: [8360936-cosmetics-1.patch.txt](https://github.com/user-attachments/files/21147228/8360936-cosmetics-1.patch.txt) -- easier to express them as patch. Untested, see if it makes sense?

-------------

PR Review: https://git.openjdk.org/jdk/pull/26072#pullrequestreview-3002334781