RFR: 8358756: [s390x] Test StartupOutput.java crash due to CodeCache size [v2]

[Amit Kumar]

On Tue, 17 Jun 2025 15:09:42 GMT, Damon Fenacci <dfenacci at openjdk.org> wrote:

>>> Thanks @offamitkumar. The idea behind the [PR](https://github.com/openjdk/jdk/pull/23630) that changed this is that it would check randomly around the amount of code cache that would be just enough for the compilers to start (or not). So, before that PR it would sometimes crash instead of terminating gently. Does adding `800k` to the initial code cache for s390 do that? Did you try before that [PR](https://github.com/openjdk/jdk/pull/23630) (or temporarily reverting it) to see if it crashes?
>> 
>> 
>> Just for my understanding. Even if test passes we still want to see this warning: 
>> 
>> [warning][codecache] CodeCache is full. Compiler has been disabled.
>> 
>> 
>> Before the PR, I don't test crashing or even producing this warning. Even with my changes same behaviour is going on.
>
>> Just for my understanding. Even if test passes we still want to see this warning:
>> 
>> ```
>> [warning][codecache] CodeCache is full. Compiler has been disabled.
>> ```
> 
> The test passes with and without that message. When the randomly chosen amount of code cache is not enough to start the compiler(s) it should print that message, when it is enough to start both compilers, you don't see that message.
> The important thing is that there is no crash when compilers are trying to reserve code cache (they should be just shut down).

@dafedafe any further comments on this one :-)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25741#issuecomment-3055235851