RFR: 8360936: Test compiler/onSpinWait/TestOnSpinWaitAArch64.java fails after JDK-8359435 [v8]
Aleksey Shipilev
shade at openjdk.org
Thu Jul 10 06:11:41 UTC 2025
On Wed, 9 Jul 2025 20:13:57 GMT, Evgeny Astigeevich <eastigeevich at openjdk.org> wrote:
>> Test compiler/onSpinWait/TestOnSpinWaitAArch64.java needs debug info to identify a position of spin wait instructions in generated code. The test switched to use `XX:CompileCommand=print` instead of `XX:+PrintAssembly` to have assembly only for a tested Java method. In release builds `XX:+PrintAssembly` prints out debug info but `XX:CompileCommand=print` does not.
>>
>> This PR reimplements the test to parse instructions and to check them. The test does not rely on debug info anymore.
>>
>> Tested on Linux and MacOS with and without hsdis:
>> - Fastdebug: test passed
>> - Slowdebug: test passed.
>> - Release: test passed.
>
> Evgeny Astigeevich has updated the pull request incrementally with one additional commit since the last revision:
>
> Apply 8360936-cosmetics-1.patch.txt from PR
Looks good to me, thanks.
-------------
Marked as reviewed by shade (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/26072#pullrequestreview-3004074308
More information about the hotspot-compiler-dev
mailing list