RFR: 8358756: [s390x] Test StartupOutput.java crash due to CodeCache size [v2]

[Amit Kumar]

On Thu, 10 Jul 2025 03:37:37 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>>> Just for my understanding. Even if test passes we still want to see this warning:
>>> 
>>> ```
>>> [warning][codecache] CodeCache is full. Compiler has been disabled.
>>> ```
>> 
>> The test passes with and without that message. When the randomly chosen amount of code cache is not enough to start the compiler(s) it should print that message, when it is enough to start both compilers, you don't see that message.
>> The important thing is that there is no crash when compilers are trying to reserve code cache (they should be just shut down).
>
> @dafedafe any further comments on this one :-)

> Sorry for the delay @offamitkumar, I left it a bit on the side...
> 
> > What I wanted to verify with above expected crash is that current number are not enough for the compilers and we saw the output is containing that "Codecache is full" message.
> 
> I think that if you want to check for the "Codecache is full..." message you should probably add a new test (as part of this regression test class) instead of changing this one as the purpose here is really to check for no crashes.

I think current modification is enough for us as well. Those message tweaks were just for my own curiosity and not required any further. Are you fine with the current changes ?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25741#issuecomment-3056293756