RFR: 8348868: AArch64: Add backend support for SelectFromTwoVector [v13]
Bhavana Kilambi
bkilambi at openjdk.org
Fri Jul 11 08:05:46 UTC 2025
On Fri, 11 Jul 2025 02:27:12 GMT, Hao Sun <haosun at openjdk.org> wrote:
>> Bhavana Kilambi has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Change match rule names to lowercase
>
> src/hotspot/cpu/aarch64/aarch64_vector.ad line 7189:
>
>> 7187: effect(TEMP_DEF dst, TEMP tmp);
>> 7188: match(Set dst (SelectFromTwoVector (Binary index src1) src2));
>> 7189: format %{ "vselect_from_two_vectors_Neon_10_11 $dst, $src1, $src2, $index\t# vector (8B/16B/4S/8S/2I/4I/2F/4F). KILL $tmp" %}
>
> nit: here and several other sites. We also need use lower cases in the `format` clause.
>
> Suggestion:
>
> format %{ "vselect_from_two_vectors_neon_10_11 $dst, $src1, $src2, $index\t# vector (8B/16B/4S/8S/2I/4I/2F/4F). KILL $tmp" %}
Sorry my bad, I missed it but the new patch (after @XiaohongGong's suggestion) doesnt have the separate neon/sve match rules anymore and I have made sure the match rule name in the format matches the match rule. Thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23570#discussion_r2199971472
More information about the hotspot-compiler-dev
mailing list