RFR: 8350896: Integer/Long.compress gets wrong type from CompressBitsNode::Value [v11]
Jatin Bhateja
jbhateja at openjdk.org
Fri Jul 11 14:16:03 UTC 2025
On Fri, 11 Jul 2025 13:46:18 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update test
>
> test/hotspot/jtreg/compiler/c2/gvn/TestBitCompressValueTransform.java line 366:
>
>> 364: res += 800;
>> 365: }
>> 366: return res;
>
> Can you please use powers-of-2 instead? That way it cannot happen that one error masks out another.
> Imagine somehow we should only add `300` (I3), but instead add `100 + 200` (I1 and I2).
Makes sense, thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23947#discussion_r2200850492
More information about the hotspot-compiler-dev
mailing list