RFR: 8359678: C2: assert(static_cast<T1>(result) == thing) caused by ReverseBytesNode::Value() [v3]
Hannes Greule
hgreule at openjdk.org
Sat Jul 12 08:16:25 UTC 2025
On Fri, 11 Jul 2025 19:54:29 GMT, Manuel Hässig <mhaessig at openjdk.org> wrote:
>> Hannes Greule has updated the pull request incrementally with one additional commit since the last revision:
>>
>> re-add package, add methods to Run annotation
>
> test/hotspot/jtreg/compiler/c2/gvn/ReverseBytesConstantsTests.java line 93:
>
>> 91: Asserts.assertEQ(Short.reverseBytes((short) 0x8070), testS3());
>> 92: Asserts.assertEQ(Short.reverseBytes(C_SHORT), testS4());
>> 93: Asserts.assertEQ(ReverseBytesConstantsHelper.reverseBytesShort(C_INT), testS5());
>
> Suggestion:
>
> // TODO: uncomment after integration of JDK-8362046
> // Asserts.assertEQ(ReverseBytesConstantsHelper.reverseBytesShort(C_INT), testS5());
I assume you mean the Character case here instead. I commented it out for now, but I agree a reviewer should acknowledge that this is the right way to go.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25988#discussion_r2202431063
More information about the hotspot-compiler-dev
mailing list