RFR: 8361492: [IR Framework] Has too restrictive regex for load and store [v2]

Damon Fenacci dfenacci at openjdk.org
Mon Jul 14 07:03:40 UTC 2025


On Mon, 14 Jul 2025 06:16:32 GMT, Marc Chevalier <mchevalier at openjdk.org> wrote:

>> Improving store and load regexes + adding test. It's mostly an improve version of a fix I had to do in Valhalla where it was blocking (part of JDK-8361250, blocking JDK-8357785).
>> 
>> The new regex takes into account that classes can implement interfaces, nested classes, and various labels after the `@`. It should be more robust.
>> 
>> Thanks,
>> Marc
>
> Marc Chevalier has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Mostly add spaces
>   
>   and rename, a bit

Well spotted @marc-chevalier and thanks for fixing it!
LGTM

-------------

Marked as reviewed by dfenacci (Committer).

PR Review: https://git.openjdk.org/jdk/pull/26269#pullrequestreview-3014997859


More information about the hotspot-compiler-dev mailing list