RFR: 8348868: AArch64: Add backend support for SelectFromTwoVector [v15]

Bhavana Kilambi bkilambi at openjdk.org
Mon Jul 14 11:32:44 UTC 2025


On Mon, 14 Jul 2025 11:20:57 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Bhavana Kilambi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Addressed review comments to half the number of match rules
>
> src/hotspot/cpu/aarch64/c2_MacroAssembler_aarch64.cpp line 2858:
> 
>> 2856: 
>> 2857: // Implement selecting from two vectors using Neon instructions
>> 2858: void C2_MacroAssembler::select_from_two_vectors_neon(FloatRegister dst, FloatRegister src1,
> 
> Need a comment here saying what this does.

Thanks for the comment. I did mention on line #2857 that this implements selecting from two vectors using Neon instructions. Do you think I should add more description here? I have also added the conditions on which this function gets called in `C2_MacroAssembler::select_from_two_vectors()`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23570#discussion_r2204669842


More information about the hotspot-compiler-dev mailing list