RFR: 8361836: RISC-V: Relax min vector length to 32-bit for short vectors [v2]

Dingli Zhang dzhang at openjdk.org
Tue Jul 15 01:30:46 UTC 2025


On Mon, 14 Jul 2025 12:19:01 GMT, Feilong Jiang <fjiang at openjdk.org> wrote:

>> Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adjust the position of comment
>
> src/hotspot/cpu/riscv/riscv.ad line 1999:
> 
>> 1997:   } else if (bt == T_SHORT) {
>> 1998:     // To support vector type conversions between short and wider types.
>> 1999:     size = 2;
> 
> Should we add some `assert` or `guarantee` for uncovered types?

Thanks for the review!
I think assert or guarantee are unnecessary for types not explicitly covered, as their behavior is safely constrained by general rules and global constraints (e.g., limit the min vector size to 8-byte and minimum size of 2).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26239#discussion_r2206096134


More information about the hotspot-compiler-dev mailing list