RFR: 8341293: Split field loads through Nested Phis [v9]

[Dhamoder Nalla]

On Tue, 17 Jun 2025 19:13:04 GMT, Cesar Soares Lucas <cslucas at openjdk.org> wrote:

>> Dhamoder Nalla has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   address CR comments
>
> src/hotspot/share/opto/escape.cpp line 1310:
> 
>> 1308:     Node* use = ophi->fast_out(i);
>> 1309:     if (use->is_Phi()) {
>> 1310:       assert(use->_idx != ophi->_idx, "Unexpected selfloop Phi.");
> 
> Should we bailout of the reduction process if we somehow end up in this situation?
> I.e., in a debug build we'll assert, but in a product build you're just ignoring the problem.

This assert is redundant; the self-loop nodes are already filtered out before reaching reduce_phi.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21270#discussion_r2207356962