RFR: 8353276: C2: simplify PhaseMacroExpand::opt_bits_test [v2]

Tobias Hartmann thartmann at openjdk.org
Wed Jul 16 06:47:49 UTC 2025


On Mon, 14 Jul 2025 18:50:23 GMT, Saranya Natarajan <snatarajan at openjdk.org> wrote:

>> **Issue** 
>> The last three parameters of `PhaseMacroExpand::opt_bits_test(Node* ctrl, Node* region, int edge, Node* word, int mask, int bits, bool return_fast_path)` are unnecessary after the fix introduced in [JDK-8256425](https://bugs.openjdk.org/browse/JDK-8256425)
>> 
>> **Fix** 
>> The proposed fix removes the last three parameters and makes the necessary modification to the methods. 
>> 
>> **Testing**
>> GitHub Actions
>> tier1 to tier5 on windows-x64, linux-x64, linux-aarch64, macosx-x64, and macosx-aarch64.
>
> Saranya Natarajan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   addressing review comments

Looks good to me too.

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/26276#pullrequestreview-3023394267


More information about the hotspot-compiler-dev mailing list