RFR: 8316694: Implement relocation of nmethod within CodeCache [v7]

Dean Long dlong at openjdk.org
Wed Jul 16 07:01:50 UTC 2025


On Tue, 15 Jul 2025 23:57:41 GMT, Chad Rakoczy <duke at openjdk.org> wrote:

> Speaking of which, seems like the NMethodState_lock is held for way too long

I can't find who posted this and what lines it refers to.  If it refers to nmethod::relocate, I don't think the lock is needed after 8358821, because nobody will be patching the relocations.

> Otherwise the nmethod could be marked not entrant after we perform the is_in_use() check

The source nmethod?  I don't see how that would cause a problem for that small block of code.  All it does to the source is call make_not_used().

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23573#issuecomment-3077174999


More information about the hotspot-compiler-dev mailing list