RFR: 8362284: RISC-V: cleanup NativeMovRegMem

Fei Yang fyang at openjdk.org
Wed Jul 16 09:26:42 UTC 2025


On Tue, 15 Jul 2025 18:41:56 GMT, Hamlin Li <mli at openjdk.org> wrote:

> Hi,
> Can you help to review this simple patch?
> 
> NativeMovRegMem on riscv is actually dead code, but still needed in case of compilation of C1.
> So make the code as simple as possible to avoid any reading and maintainance effort.
> 
> No tests, as `offset()` and `set_offset()` were Unimplemented and used in C1 and never triggered before.
> 
> Thanks!

Thanks for the cleanup. Looks fine modulo one minor comment.

src/hotspot/cpu/riscv/nativeInst_riscv.hpp line 232:

> 230: inline NativeMovRegMem* nativeMovRegMem_at(address addr) {
> 231:   Unimplemented();
> 232:   return (NativeMovRegMem*)0;

Maybe: `return (NativeMovRegMem*)nullptr;`

-------------

Marked as reviewed by fyang (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/26328#pullrequestreview-3023955944
PR Review Comment: https://git.openjdk.org/jdk/pull/26328#discussion_r2209781232


More information about the hotspot-compiler-dev mailing list