RFR: 8359965: Enable paired pushp and popp instruction usage for APX enabled CPUs [v4]

Sandhya Viswanathan sviswanathan at openjdk.org
Wed Jul 16 20:57:47 UTC 2025


On Wed, 16 Jul 2025 00:06:53 GMT, Srinivas Vamsi Parasa <sparasa at openjdk.org> wrote:

>> The goal of this PR is to enhance the existing x86 assembly stubs using PUSH and POP instructions with paired PUSHP/POPP instructions which are part of Intel APX technology.
>> 
>> In Intel APX, the PUSHP and POPP instructions are modern, compact replacements for the legacy PUSH and POP, designed to work seamlessly with the expanded set of 32 general-purpose registers (R0–R31). Unlike their predecessors, they use the new APX (REX2-based) encoding, enabling more uniform and efficient instruction formats. These instructions improve code density, simplify register access, and are optimized for performance on APX-enabled CPUs.
>> 
>> Pairing PUSHP and POPP in Intel APX provides CPU-level benefits such as more efficient instruction decoding, better stack pointer tracking, and improved register dependency management. Their uniform encoding allows for streamlined execution, reduced pipeline stalls, and potential micro-op fusion, all of which enhance performance and power efficiency. This pairing helps the processor optimize speculative execution and register lifetimes, making code faster and more scalable on modern architectures.
>
> Srinivas Vamsi Parasa has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
> 
>  - merge with master
>  - remove pushp/popp from vm_version_x86 and also when APX is not being used
>  - rename to paired_push and paired_pop
>  - 8359965: Enable paired pushp and popp instruction usage for APX enabled CPUs

src/hotspot/cpu/x86/macroAssembler_x86.cpp line 798:

> 796: }
> 797: 
> 798: void MacroAssembler::paired_push(Register src) {

Would be better to call these as push_ppx and pop_ppx.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25889#discussion_r2211592540


More information about the hotspot-compiler-dev mailing list