RFR: 8362493: Cleanup CodeBuffer::copy_relocations_to

Hamlin Li mli at openjdk.org
Mon Jul 21 09:05:41 UTC 2025


On Thu, 17 Jul 2025 12:14:08 GMT, Manuel Hässig <mhaessig at openjdk.org> wrote:

>> Hi,
>> Can you help to review this simple patch?
>> 
>> `CodeBuffer::copy_relocations_to(address buf, csize_t buf_limit, bool only_inst)` is only used in `copy_relocations_to(CodeBlob* dest)` which passes false to only_inst, so the former one should be able to be simplified.
>> 
>> Thank you!
>
> Thank you for working on this cleanup, @Hamlin-Li! It looks good to me.
> 
> I kicked off some testing on our side and will let you know what the results are.

Hi @mhaessig , how's your test result? I guess it should be fine. Thanks

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26366#issuecomment-3095807017


More information about the hotspot-compiler-dev mailing list