RFR: 8316694: Implement relocation of nmethod within CodeCache [v38]

Vladimir Kozlov kvn at openjdk.org
Mon Jul 21 23:59:34 UTC 2025


On Mon, 21 Jul 2025 23:38:27 GMT, Chad Rakoczy <duke at openjdk.org> wrote:

>> src/hotspot/share/code/nmethod.cpp line 1164:
>> 
>>> 1162: #endif
>>> 1163:     + align_up(debug_info->data_size()                , oopSize)
>>> 1164:     + align_up(ImmutableDataReferencesCounterSize     , oopSize);
>> 
>> Why you need to realign this? There is no requirement to have spaces before `,`
>
> It was aligned this way before my change. The addition of `ImmutableDataReferencesCounterSize` requires more spaces to keep it the same.

No it does not - you have a lot of unneeded spaces after `ImmutableDataReferencesCounterSize`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23573#discussion_r2220600736


More information about the hotspot-compiler-dev mailing list