RFR: 8348868: AArch64: Add backend support for SelectFromTwoVector
Bhavana Kilambi
bkilambi at openjdk.org
Tue Jul 22 08:09:31 UTC 2025
On Fri, 6 Jun 2025 01:24:28 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:
>>> Good job @Bhavana-Kilambi ! Generally looks good to me. Just some minor issues that I have left the comments. Besides, could you please add some IR tests for this optimization? Thanks!
>>
>> Hi @XiaohongGong , there are tests already for this operation under `jdk/jdk/incubator/vector` for all the types and sizes to verify the results. Did you mean IR tests for verifying if the correct backend match rule is being generated ?
>
>> > Good job @Bhavana-Kilambi ! Generally looks good to me. Just some minor issues that I have left the comments. Besides, could you please add some IR tests for this optimization? Thanks!
>>
>> Hi @XiaohongGong , there are tests already for this operation under `jdk/jdk/incubator/vector` for all the types and sizes to verify the results. Did you mean IR tests for verifying if the correct backend match rule is being generated ?
>
> Yes, I think adding an IR check tests for this operation will be better. I think checking the mid-end IR is enough.
Hi @XiaohongGong @theRealAph @shqking Can I please ask for another round of review for the latest patch? Thanks in advance!
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23570#issuecomment-3101552923
More information about the hotspot-compiler-dev
mailing list