RFR: 8350896: Integer/Long.compress gets wrong type from CompressBitsNode::Value [v16]
Jatin Bhateja
jbhateja at openjdk.org
Tue Jul 22 10:28:11 UTC 2025
On Tue, 22 Jul 2025 10:24:43 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:
>> Hi All,
>>
>> This bugfix patch fixes incorrect value computation for Integer/Long. compress APIs.
>>
>> Problems occur with a constant input and variable mask where the input's value is equal to the lower bound of the mask value., In this case, an erroneous value range estimation results in a constant value. Existing value routine first attempts to constant fold the compression operation if both input and compression mask are constant values; otherwise, it attempts to constrain the value range of result based on the upper and lower bounds of mask type.
>>
>> New IR test covers the issue reported in the bug report along with a case for value range based logic pruning.
>>
>> Kindly review and share your feedback.
>>
>> Best Regards,
>> Jatin
>
> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>
> Update intrinsicnode.cpp
Hi @kvn, Apart from couple of lines of fix, patch mainly re-structured existing handling and added additional comments and proofs along with an exhaustive test.
So effective code changes are very minimal. Should I check-in this in jdk-mainline and then prepare minimal fix (if needed) for jdk25 ?
-------------
PR Review: https://git.openjdk.org/jdk/pull/23947#pullrequestreview-3042257403
More information about the hotspot-compiler-dev
mailing list